Update HttpService.yaml #966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information for HTTP methods, what they are, and if they are currently supported by Roblox's HTTPService
github-actions
bot
added
the
engine reference
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
changes requested
Added https://developer.mozilla.org/ to the list of allowed HTTP links
Contributor
Author
|
https://developer.mozilla.org/ is a resource for all things web-development. The links in the proposed changes for HttpService.yaml link to detailed info on each of the listed HTTP methods. |
guessing the check system doesn't whitelist all child urls under a parent url
Contributor
Author
|
Please lmk if parent URLs whitelist child URLs, I don't want to clutter the allowedlinks file |
Contributor
Author
|
I'm just going to close and reopen this request as it doesn't seem to recognize the changes being made to tools/checks/utils/allowedHttpLinks.txt |
IgnisRBX
pushed a commit
that referenced
this pull request
Jan 23, 2025
…s. (#978) ## Changes Updated HttpService.yaml to provide a short description of each of the HTTP methods, if they are permitted via Roblox scripts, and Mozilla resources for each. This is a duplicate of pull request #966 as the checks did not seem to recognize the changes made to tools/checks/utils/allowedHttpLinks.txt to allow the links to Mozilla resources on each of the HTTP methods. The only method not currently permitted by Roblox is the CONNECT method which creates a secure information tunnel between the requested and originating server. Makes sense why this isn't allowed, but its useful information to include nonetheless. ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added information for HTTP methods, what each of them are, and if they are currently supported by Roblox's HTTPService.
Connect is the only method not currently supported. This is likely because it creates an information tunnel between the target server and the server requesting the connection. I can provide the code I used to test each of the methods, but it's just a pretty simple express server and Roblox script. I'll make a feature request for the Connect method but I think its pretty unlikely that will ever get added.
I also don't know if it's a problem that I linked 3rd party sources (Mozilla Docs), but Roblox doesn't have pages for the individual HTTP methods and I don't believe it would make sense to add individual pages for them as it entirely relates to the HTTPService.
Checks
By submitting your pull request for review, you agree to the following: